<div dir="ltr">Hi Yugo<div><br></div><div><div class="gmail_extra">Many thanks for the patch. Although the patch takes care of zombie processes, but I think blocking the watchdog process at time of escalation and de-escalation might lead to some un-expected results, because at that time when the watchdog process will be waiting for the escalation/de-escalation process to finish it would not be replying to other nodes. </div><div class="gmail_extra">So can you please have a look at the attached path which uses the SIGCHILD to handle the zombie process problem</div><div class="gmail_extra"><br></div><div class="gmail_extra">Thanks</div><div class="gmail_extra">Best regards</div><div class="gmail_extra">Muhammad Usama</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 28, 2015 at 2:11 PM, Yugo Nagata <span dir="ltr"><<a href="mailto:nagata@sraoss.co.jp" target="_blank">nagata@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Usama,<br>
<br>
I write the patch to fix it.<br>
<br>
In current, escalation process is forked but not waited by watchdog<br>
process. Fix is to wait the escalation process by waitpid. That is,<br>
watchdog is blocked while waiting the escalation finishing.<br>
<br>
Any comment?<br>
<br>
Regards,<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, 21 Dec 2015 16:46:33 +0900<br>
Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>> wrote:<br>
<br>
> Usama,<br>
><br>
> A zombie process appeared after pgpool started with watchdog.<br>
><br>
> $ ps aux | grep pgpool<br>
> ...<br>
> yugo-n 32156 0.0 0.0 19880 1244 pts/27 S 16:31 0:00 pgpool: watchdog<br>
> yugo-n 32165 0.0 0.0 0 0 pts/27 Z 16:31 0:00 [pgpool] <defunct><br>
> yugo-n 32166 0.0 0.0 17792 768 pts/27 S 16:31 0:00 pgpool: lifecheck<br>
> ...<br>
><br>
> I found PID 32165 was pid of the escalation process.<br>
><br>
> 2015-12-21 16:31:33: pid 32156: LOG: escalation process started with PID:32165<br>
> 2015-12-21 16:31:33: pid 32165: LOG: watchdog: escalation started<br>
><br>
> I can reproduce this on Ubuntu but not CentOS.<br>
><br>
> Regarads,<br>
> --<br>
> Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
> _______________________________________________<br>
> pgpool-hackers mailing list<br>
> <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Yugo Nagata <<a href="mailto:nagata@sraoss.co.jp">nagata@sraoss.co.jp</a>><br>
</font></span><br>_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
<br></blockquote></div><br></div></div></div>