<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 9, 2015 at 12:51 PM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Better to post to pgpool-hackers...<br>
<br>
> Usama,<br>
><br>
> While installing pgpool_adm extension, I noticed that sometimes<br>
> pgpool_adm.so failed to load because missing reference to libpcp.so.<br>
> To fix this, I have changed src/sql/pgpool_adm/Makefile as follows:<br>
><br>
>> SHLIB_LINK = -L../../libs/pcp/.libs -lpcp<br>
><br>
> <S HLIB_LINK = -L../../libs/pcp/.libs -lpcp -Wl,--as-needed -Wl,-rpath,'${libdir}',--enable-new-dtags<br>
><br>
> Problem is, ${libdir} is expanded to the libdir where PostgreSQL's<br>
> libraries installed (including pgpool_adm.so). But my intention was<br>
> ${libdir} to point to the libdir which is not necessarily same as<br>
> PostgreSQL libdir. It's best to point to the directory (prefix/lib<br>
> where prefix is specified by configure). Any idea how to fix?<br></blockquote><div><br></div><div>One way to do this is to add a new <a href="http://Makefile.config.in">Makefile.config.in</a> file in src/sql/ directory and then make the configure to generate a Makefile.config by substitute the actual prefix path in it. And then pgpool_adm module's Makefile can include that Makefile.config</div><div>Please see the attached POC patch</div><div><br></div><div>Thanks</div><div>Best regards</div><div>Muhammad Usama</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> Best regards,<br>
> --<br>
> Tatsuo Ishii<br>
> SRA OSS, Inc. Japan<br>
> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
><br>
>> Add pgpool_adm docs.<br>
>><br>
>> Also enhance Makefile of pgpool_adm to replace the SHLIB_LINK to add<br>
>> modern ld flags. Still have problem though: i.e. ${libdir} should not<br>
>> be replaced by PostgreSQL's lib dir, rather than pcplib dir installing<br>
>> dir.<br>
>><br>
>> Branch<br>
>> ------<br>
>> master<br>
>><br>
>> Details<br>
>> -------<br>
>> <a href="http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f690f9927847c743dfa97dbd3371717a43ea4231" rel="noreferrer" target="_blank">http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f690f9927847c743dfa97dbd3371717a43ea4231</a><br>
>><br>
>> Modified Files<br>
>> --------------<br>
>> doc/pgpool-en.html | 315 ++++++++++++++++++++++++++++++++++++++++++-<br>
>> doc/pgpool_adm.odp | Bin 0 -> 17456 bytes<br>
>> doc/pgpool_adm.png | Bin 0 -> 32437 bytes<br>
>> src/sql/pgpool_adm/Makefile | 5 +-<br>
>> 4 files changed, 317 insertions(+), 3 deletions(-)<br>
>><br>
>> _______________________________________________<br>
>> pgpool-committers mailing list<br>
>> <a href="mailto:pgpool-committers@pgpool.net">pgpool-committers@pgpool.net</a><br>
>> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-committers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-committers</a><br>
> _______________________________________________<br>
> pgpool-committers mailing list<br>
> <a href="mailto:pgpool-committers@pgpool.net">pgpool-committers@pgpool.net</a><br>
> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-committers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-committers</a><br>
_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</blockquote></div><br></div></div>