<div dir="ltr">Hi<div><br></div><div>I have pushed the fix for the above issues.</div><div><br></div><div>Thanks</div><div>Best regards</div><div>Muhammad Usama</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 15, 2015 at 5:49 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Usama,<br>
<br>
Can you please fix below? It seems it was introduced by you.<br>
<br>
-------------------------------------------------------------------------------------------<br>
1) pool_memqcacache.c<br>
<br>
/*<br>
1107 * This need to live throughout the life of child so home it in<br>
1108 * TopMemoryContext<br>
1109 */<br>
1110 oldcxt = MemoryContextSwitchTo(TopMemoryContext);<br>
1111 tmp = repalloc(oidbuf, sizeof(int) * oidbuf_size);<br>
CID 1304568 (#1 of 1): Unused value (UNUSED_VALUE)returned_pointer: Pointer oldcxt returned by MemoryContextSwitchTo(oldcxt) is never used.<br>
1112 oldcxt = MemoryContextSwitchTo(oldcxt);<br>
<br>
-------------------------------------------------------------------------------------------<br>
<br>
2) pcp.c<br>
<br>
620 else<br>
CID 1261615 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement pcp_internal_error(pcpConn,....<br>
621 pcp_internal_error(pcpConn,<br>
622 "command failed. invalid response");<br>
<br>
<br>
904<br>
assignment: Assigning: index = (char *)memchr(index, 0, len) + 1.<br>
905 index = (char *) memchr(index, '\0', len) + 1;<br>
notnull: At condition index == NULL, the value of index cannot be NULL.<br>
dead_error_condition: The condition index == NULL cannot be true.<br>
906 if(index == NULL)<br>
CID 1261613 (#1 of 12): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement goto INVALID_RESPONSE;.<br>
907 goto INVALID_RESPONSE;<br>
908<br>
<br>
1<br>
assignment: Assigning: index = (char *)memchr(index, 0, len) + 1.<br>
1112 index = (char *) memchr(index, '\0', len) + 1;<br>
notnull: At condition index == NULL, the value of index cannot be NULL.<br>
dead_error_condition: The condition index == NULL cannot be true.<br>
1113 if(index == NULL)<br>
CID 1261612 (#1 of 3): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this statement goto INVALID_RESPONSE;.<br>
<br>
-------------------------------------------------------------------------------------------<br>
3) pcp_worker.c<br>
<br>
arith_non_null: The result of pointer arithmetic (char *)memchr(buf, 0, len) + 1 is never null.<br>
assignment: Assigning: param_value = (char *)memchr(buf, 0, len) + 1.<br>
1188 param_value = (char *) memchr(buf, '\0', len) + 1;<br>
notnull: At condition param_value == NULL, the value of param_value cannot be NULL.<br>
dead_error_condition: The condition param_value == NULL cannot be true.<br>
1189 if(param_value == NULL)<br>
1190 ereport(ERROR,<br>
1191 (errmsg("set configuration parameter failed"),<br>
CID 1261611 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement do {<br>
<br>
int const elevel_ =....<br>
1192 errdetail("invalid pcp packet received from client")));<br>
1193<br>
-------------------------------------------------------------------------------------------<br>
<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</blockquote></div><br></div>