<div dir="ltr">Hi Tatsuo,<div><br></div><div style>Assuming there are no issues when are you planning to commit the directory structure changes? I believe we would like these to be part of pgpool 3.4.</div><div style><br></div>
<div style>-- Ahsan</div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 15, 2013 at 5:09 PM, Muhammad Usama <span dir="ltr"><<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Tatsuo</div><div><br></div>Thanks for your feedback, I have made the suggested changes and pushed to the github repository.<span class="HOEnZb"><font color="#888888"><div>
<br></div><div>--Usama </div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Jul 11, 2013 at 3:39 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Usama,<br>
<br>
Thanks for the proposal. In over all I believe this will greatly help<br>
people who are trying to understand the pgpool-II source code. After<br>
pgpool-II 3.3 is out (which is expected in this July), we could apply<br>
the changes if there's no objection from pgpool-II hackers.<br>
<div><br>
> Since the pgpool-II code base has grown in recent times and the code tree<br>
> is not very much organised into directories i.e There are<br>
> no separate directories for source and include files, and most of the pgpool-II<br>
> source resides in top level pgpool2 directory, This makes it a little hard<br>
> to get the quick understanding of the code for new developers,<br>
> and maintenance of code will become more and more difficult with growth in<br>
> code base.<br>
><br>
> So me and Tatsuo has been working on the reorganisation of pgpool-II source<br>
> tree and have came up with the directory structure.<br>
> The purposed source tree for the pgpool-II is to contains following<br>
> directories.<br>
<br>
</div>Here are small suggestions.<br>
<br>
I think you missed to create src/include/query_cache and you should<br>
move src/include/utils/pool_memqcache.h there.<br>
<br>
Also I think src/rewrite/parallel_query should not under src/rewrite<br>
because staffs under parallel_query are not for general query<br>
rewriting, but for parallel_query. They look similar in implementation<br>
but their aims are completely different. If you do that way, it will<br>
give enough confusion to those who are studying pgpool-II source code.<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
<div><div><br>
> pgpool2<br>
> | --doc<br>
> | --m4<br>
> | --pgpool_adm<br>
> | --src<br>
> | | --auth<br>
> | | --config<br>
> | | --context<br>
> | | --include<br>
> | | | --auth<br>
> | | | --context<br>
> | | | --parser<br>
> | | | --pcp<br>
> | | | --protocol<br>
> | | | --rewrite<br>
> | | | --utils<br>
> | | | --watchdog<br>
> | | --libs<br>
> | | | --pcp<br>
> | | --main<br>
> | | --parser<br>
> | | --pcp_con<br>
> | | --protocol<br>
> | | --query_cache<br>
> | | --redhat<br>
> | | | --rpm_installer<br>
> | | --rewrite<br>
> | | | --parallel_query<br>
> | | --sample<br>
> | | --sql<br>
> | | | --pgpool-recovery<br>
> | | | --pgpool-regclass<br>
> | | --streaming_replication<br>
> | | --system_db<br>
> | | --test<br>
> | | | --C<br>
> | | | --jdbc<br>
> | | | | --expected<br>
> | | | --parser<br>
> | | | | --expected<br>
> | | | | --input<br>
> | | | --pdo-test<br>
> | | | | --mod<br>
> | | | | --SQLlist<br>
> | | | --regression<br>
> | | | | --tests<br>
> | | | | | --001.load_balance<br>
> | | | | | --002.native_replication<br>
> | | | | | --003.failover<br>
> | | | | | --050.bug58<br>
> | | | | | --051.bug60<br>
> | | | | | --052.do_query<br>
> | | | | | --053.insert_lock_hangs<br>
> | | | --timestamp<br>
> | | | | --expected<br>
> | | | | --input<br>
> | | --tools<br>
> | | | --pcp<br>
> | | | --pgmd5<br>
> | | --utils<br>
> | | --watchdog<br>
> | | | --test<br>
><br>
><br>
> I have created a git repository on github (<a href="https://github.com/codeforall" target="_blank">https://github.com/codeforall</a><br>
> /pgpool2.git) with the purposed directory structure.<br>
> and the attached (pgpool2_code_tree.txt) file contains the complete list<br>
> directories along with files for the purposed directory structure.<br>
><br>
> Thanks<br>
><br>
> Regards<br>
> Muhammad Usama<br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Ahsan Hadi<br>Snr Director Product Development<br>EnterpriseDB Corporation<br>The Enterprise Postgres Company<br><br>Phone: +92-51-8358874 <br>Mobile: +92-333-5162114<br>
<br>Website: <a href="http://www.enterprisedb.com">www.enterprisedb.com</a><br>EnterpriseDB Blog: <a href="http://blogs.enterprisedb.com/">http://blogs.enterprisedb.com/</a><br>Follow us on Twitter: <a href="http://www.twitter.com/enterprisedb">http://www.twitter.com/enterprisedb</a><br>
<br>This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
</div>