<div dir="ltr"><div>Hi Tatsuo</div><div><br></div>Thanks for your feedback, I have made the suggested changes and pushed to the github repository.<div><br></div><div>--Usama </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Jul 11, 2013 at 3:39 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Usama,<br>
<br>
Thanks for the proposal. In over all I believe this will greatly help<br>
people who are trying to understand the pgpool-II source code. After<br>
pgpool-II 3.3 is out (which is expected in this July), we could apply<br>
the changes if there's no objection from pgpool-II hackers.<br>
<div class="im"><br>
> Since the pgpool-II code base has grown in recent times and the code tree<br>
> is not very much organised into directories i.e There are<br>
> no separate directories for source and include files, and most of the pgpool-II<br>
> source resides in top level pgpool2 directory, This makes it a little hard<br>
> to get the quick understanding of the code for new developers,<br>
> and maintenance of code will become more and more difficult with growth in<br>
> code base.<br>
><br>
> So me and Tatsuo has been working on the reorganisation of pgpool-II source<br>
> tree and have came up with the directory structure.<br>
> The purposed source tree for the pgpool-II is to contains following<br>
> directories.<br>
<br>
</div>Here are small suggestions.<br>
<br>
I think you missed to create src/include/query_cache and you should<br>
move src/include/utils/pool_memqcache.h there.<br>
<br>
Also I think src/rewrite/parallel_query should not under src/rewrite<br>
because staffs under parallel_query are not for general query<br>
rewriting, but for parallel_query. They look similar in implementation<br>
but their aims are completely different. If you do that way, it will<br>
give enough confusion to those who are studying pgpool-II source code.<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
<div class="HOEnZb"><div class="h5"><br>
> pgpool2<br>
> | --doc<br>
> | --m4<br>
> | --pgpool_adm<br>
> | --src<br>
> | | --auth<br>
> | | --config<br>
> | | --context<br>
> | | --include<br>
> | | | --auth<br>
> | | | --context<br>
> | | | --parser<br>
> | | | --pcp<br>
> | | | --protocol<br>
> | | | --rewrite<br>
> | | | --utils<br>
> | | | --watchdog<br>
> | | --libs<br>
> | | | --pcp<br>
> | | --main<br>
> | | --parser<br>
> | | --pcp_con<br>
> | | --protocol<br>
> | | --query_cache<br>
> | | --redhat<br>
> | | | --rpm_installer<br>
> | | --rewrite<br>
> | | | --parallel_query<br>
> | | --sample<br>
> | | --sql<br>
> | | | --pgpool-recovery<br>
> | | | --pgpool-regclass<br>
> | | --streaming_replication<br>
> | | --system_db<br>
> | | --test<br>
> | | | --C<br>
> | | | --jdbc<br>
> | | | | --expected<br>
> | | | --parser<br>
> | | | | --expected<br>
> | | | | --input<br>
> | | | --pdo-test<br>
> | | | | --mod<br>
> | | | | --SQLlist<br>
> | | | --regression<br>
> | | | | --tests<br>
> | | | | | --001.load_balance<br>
> | | | | | --002.native_replication<br>
> | | | | | --003.failover<br>
> | | | | | --050.bug58<br>
> | | | | | --051.bug60<br>
> | | | | | --052.do_query<br>
> | | | | | --053.insert_lock_hangs<br>
> | | | --timestamp<br>
> | | | | --expected<br>
> | | | | --input<br>
> | | --tools<br>
> | | | --pcp<br>
> | | | --pgmd5<br>
> | | --utils<br>
> | | --watchdog<br>
> | | | --test<br>
><br>
><br>
> I have created a git repository on github (<a href="https://github.com/codeforall" target="_blank">https://github.com/codeforall</a><br>
> /pgpool2.git) with the purposed directory structure.<br>
> and the attached (pgpool2_code_tree.txt) file contains the complete list<br>
> directories along with files for the purposed directory structure.<br>
><br>
> Thanks<br>
><br>
> Regards<br>
> Muhammad Usama<br>
</div></div></blockquote></div><br></div>