<div dir="ltr">Thanks Tatsuo.<div><br></div><div>Congratulations Usama for getting your first feature patch committed to pgpool.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 28, 2013 at 7:34 PM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Usama,<br>
<br>
Thanks for the patch. I did a simple test and it worked great. I have<br>
committed your patch along with Japanese doc (and slight editing of<br>
English doc).<br>
<div class="HOEnZb"><div class="h5">--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
> Hi Tatsuo<br>
><br>
> Please find the updated patch which takes care of the comments and<br>
> suggestions on the previous version.<br>
> Appart from documentation additions, the attached patch sets the default<br>
> search_primary_node_timeout value to 10 and setting the same to 0 will make<br>
> the pgpool-II to keep searching the primary node forever.<br>
><br>
> Thanks<br>
> Muhammad Usama<br>
><br>
><br>
><br>
> On Mon, May 27, 2013 at 7:32 PM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
><br>
>> > Hi Tatsuo<br>
>> ><br>
>> > Thanks for the comments and review. I will submit the updated patch after<br>
>> > taking care of the comments.<br>
>> > Please just clarify on one of the points, what should be the correct<br>
>> > behaviour of setting the search_primary_node_timeout = 0<br>
>> ><br>
>> > Retrying forever OR Try just one time.?<br>
>> ><br>
>> > Thanks<br>
>> > Usama<br>
>><br>
>> I vote for "retrying forever".<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
>><br>
>> > On Mon, May 27, 2013 at 7:07 PM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>><br>
>> wrote:<br>
>> ><br>
>> >> Hi Usama,<br>
>> >><br>
>> >> Welcome to pgpool developer's community!<br>
>> >><br>
>> >> > I have been working on pgpool-II TODO item to add a new configuration<br>
>> >> > parameter for searching the primary node timeout after failover.<br>
>> >> Currently<br>
>> >> > pgpool-II uses "recovery_timeout" config parameter as a timeout for<br>
>> >> > searching the primary node after failover which is not originally<br>
>> meant<br>
>> >> for<br>
>> >> > the purpose.<br>
>> >> > The attached small patch is my first pgpool-II patch which adds the<br>
>> new<br>
>> >> > configuration parameter "search_primary_node_timeout", which can be<br>
>> used<br>
>> >> > for setting the timeout for searching the primary node after failover.<br>
>> >><br>
>> >> I have looked into the patch. Here's my comment. First, you need<br>
>> >> patch for doc/pgpool-en.html.<br>
>> >><br>
>> >> Second,<br>
>> >><br>
>> >> +search_primary_node_timeout = 90<br>
>> >> + # Timeout in seconds to search for<br>
>> the<br>
>> >> + # primary node at failover<br>
>> >> + # 0 means no wait<br>
>> >><br>
>> >> I am not sure what you suppose when search_primary_node_timeout = 0.<br>
>> >> If you mean retrying forever, the code below does not do that. Rather,<br>
>> >> find_primary_node() is never called, thus<br>
>> >> find_primary_node_repeatedly() always returns -1.<br>
>> >><br>
>> >> + for (sec = 0; sec < pool_config->search_primary_node_timeout;<br>
>> >> sec++)<br>
>> >> {<br>
>> >> node_id = find_primary_node();<br>
>> >><br>
>> >> Third, the default timeout 90 seconds seems too long. Promoting to<br>
>> >> primary should take less than 10 seconds unless there's huge back log<br>
>> >> of WAL. What about set the default to 10?<br>
>> >> --<br>
>> >> Tatsuo Ishii<br>
>> >> SRA OSS, Inc. Japan<br>
>> >> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>> >> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
>> >><br>
>><br>
</div></div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
pgpool-hackers mailing list<br>
<a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Ahsan Hadi<br>Snr Director Product Development<br>EnterpriseDB Corporation<br>The Enterprise Postgres Company<br><br>Phone: +92-51-8358874 <br>Mobile: +92-333-5162114<br>
<br>Website: <a href="http://www.enterprisedb.com">www.enterprisedb.com</a><br>EnterpriseDB Blog: <a href="http://blogs.enterprisedb.com/">http://blogs.enterprisedb.com/</a><br>Follow us on Twitter: <a href="http://www.twitter.com/enterprisedb">http://www.twitter.com/enterprisedb</a><br>
<br>This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
</div>