<div dir="ltr">Thanks Ishii. However there is another compile issue with pgpool-walrecrunning that I failed to notice it earlier. Enum WalRcvState has been changed in postgres 9.3 as well and it has removed WALRCV_RUNNING state. Instead added WALRCV_STREAMING state.<div>
<br></div><div style>Please see the attached patch to fix that. This will make it compile-able but I am not sure if its an appropriate change. Because according to WalRcvRunning() function in postgres "if (state != WALRCV_STOPPED)" means its running but since previously only </div>
<div style>WALRCV_RUNNING was being checked, I have tested the WALRCV_STREAMING state only.<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Regards,</div><div class="gmail_extra">--Asif<br><br><div class="gmail_quote">
On Wed, Apr 3, 2013 at 12:53 PM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I have made slight change to your patch because of compiler<br>
warnings(htup_details.h needed). Also I think we shoudl apply the<br>
patch to V3.0 or higher as well because people might want to use the<br>
pgpool version and PostgreSQL 9.3 together.<br>
<br>
I'm waiting for <a href="http://git.postgresql.org" target="_blank">git.postgresql.org</a> allows to push again...<br>
<div><div class="h5">--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
> Looks good. Thanks.<br>
> --<br>
> Tatsuo Ishii<br>
> SRA OSS, Inc. Japan<br>
> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
><br>
>> Sure. Here is the updated patch.<br>
>><br>
>> Regards,<br>
>> --Asif<br>
>><br>
>> On Tue, Apr 2, 2013 at 5:33 PM, Tatsuo Ishii <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
>><br>
>>> In this you can put ifdef to adopt different version of PostgreSQL<br>
>>> source codes. Can you please try in that way? Following is the similar<br>
>>> technique used in sql/pgpool-regclass/pgpool-regclass.c.<br>
>>><br>
>>> #if !defined(PG_VERSION_NUM) || (PG_VERSION_NUM < 90200)<br>
>>> result = RangeVarGetRelid(rel, true);<br>
>>> #else<br>
>>> /* RangeVarGetRelid() of PostgreSQL 9.2 or later, has third<br>
>>> * argument "missing_ok" which suppresses ERROR exception, but<br>
>>> * returns invlaid_oid. See include/catalog/namespace.h */<br>
>>> result = RangeVarGetRelid(rel, true, true);<br>
>>> #endif<br>
>>> --<br>
>>> Tatsuo Ishii<br>
>>> SRA OSS, Inc. Japan<br>
>>> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>>> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
>>><br>
>>><br>
>>> > Yes its not yet released. I am compiling against latest postgres source<br>
>>> > i.e. 9.3devel master branch.<br>
>>> > Since pgpool-II master branch is also yet under development I thought it<br>
>>> > should be able to compile with it.<br>
>>> ><br>
>>> > Regards,<br>
>>> > --Asif<br>
>>> > On Apr 2, 2013 4:50 PM, "Tatsuo Ishii" <<a href="mailto:ishii@postgresql.org">ishii@postgresql.org</a>> wrote:<br>
>>> ><br>
>>> >> > Here is the patch to fix a compilation error I faced while compiling<br>
>>> the<br>
>>> >> > pgpool2/sql/pgpool-recovery. I faced the following error:<br>
>>> >> ><br>
>>> >> > pgpool-recovery.c:201:2: error: too few arguments to function<br>
>>> >> > ‘LookupExplicitNamespace’<br>
>>> >> ><br>
>>> >> > I looked into it and found out that the signature<br>
>>> >> > of LookupExplicitNamespace function has been changed in the postgres<br>
>>> >> code.<br>
>>> >><br>
>>> >> What version of PostgreSQL are you compiling pgpool-recovery.c<br>
>>> >> against? I suspect you are compiling it against not-yet-released<br>
>>> >> version of PostgreSQL.<br>
>>> >> --<br>
>>> >> Tatsuo Ishii<br>
>>> >> SRA OSS, Inc. Japan<br>
>>> >> English: <a href="http://www.sraoss.co.jp/index_en.php" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
>>> >> Japanese: <a href="http://www.sraoss.co.jp" target="_blank">http://www.sraoss.co.jp</a><br>
>>> >><br>
>>><br>
</div></div>> _______________________________________________<br>
> pgpool-hackers mailing list<br>
> <a href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a><br>
> <a href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers" target="_blank">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a><br>
</blockquote></div><br></div></div>