<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
The change looks good, but it doesn't include what I added so the
reload() function would also check the pcp.conf and pg_hba.conf. It
does a couple other things, too:<br>
- pg_hba.conf and pcp.conf are easy to relocate<br>
- reload uses "pgpool reload" instead of "killproc -HUP"<br>
<br>
I've attached a diff with my changes applied to a version that
includes your changes.<br>
<br>
<br>
alex<br>
<br>
On 6/1/12 12:05 AM, Yugo Nagata wrote:
<blockquote cite="mid:20120601160557.b49700a6.nagata@sraoss.co.jp"
type="cite">
<pre wrap="">Hello, Devrim
I have fixed the pgpool.init to stop pgpool using by "pgpool stop -m f".
Option '-m f' is meant to stop pgpool successfully even when connected
from some frontend.
In your original pgpool.init, stop() runs "pgpool stop &" as a
background process (with '&'). (although it is commented out...)
This allows new pgpool to start before old pgpool completely stop,
so I removed '&'.
I have attached the patch.
Could you please review it?
On Wed, 23 May 2012 18:56:51 -0400
Devrim GÜNDÜZ <a class="moz-txt-link-rfc2396E" href="mailto:devrim@gunduz.org"><devrim@gunduz.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi,
I'm returning from a trip today, I'll look at it on Friday or Monday.
Still, I am not maintaining the init script in the tarball for a long
time. Instead, I'm maintaining
<a class="moz-txt-link-freetext" href="http://svn.pgrpms.org/browser/rpm/redhat/9.1/pgpool-II/EL-6/pgpool.init">http://svn.pgrpms.org/browser/rpm/redhat/9.1/pgpool-II/EL-6/pgpool.init</a>
(please reload the page if you get errors)
I will review the version in the tarball, and send necessary fixes.
Regards, Devrim
On Thu, 2012-05-17 at 12:07 +0900, Yugo Nagata wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Dear Mr. Devrim
An problem with restart using redhat/pgpool.init has been reported to the bug
track.
<a class="moz-txt-link-freetext" href="http://www.pgpool.net/mantisbt/view.php?id=12">http://www.pgpool.net/mantisbt/view.php?id=12</a>
When pgpool is connected from frontend (e.g. psql), restart using
redhat/pgpool.init fails with error like
"bind(/tmp/.s.PGSQL.9898) failed. reason: Address already in use".
There is no probrem when using `pgpool -m f stop; pgpool`.
Would killproc fail to close the socket properly?
I heard from Tatsuo Ishii that you are in charge of redhat/pgpool.init.
Could you respond to the issue?
</pre>
</blockquote>
<pre wrap="">
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: <a class="moz-txt-link-freetext" href="http://www.enterprisedb.com">http://www.enterprisedb.com</a>
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Community: devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
<a class="moz-txt-link-freetext" href="http://www.gunduz.org">http://www.gunduz.org</a> Twitter: <a class="moz-txt-link-freetext" href="http://twitter.com/devrimgunduz">http://twitter.com/devrimgunduz</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
pgpool-hackers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:pgpool-hackers@pgpool.net">pgpool-hackers@pgpool.net</a>
<a class="moz-txt-link-freetext" href="http://www.pgpool.net/mailman/listinfo/pgpool-hackers">http://www.pgpool.net/mailman/listinfo/pgpool-hackers</a>
</pre>
</blockquote>
<br>
</body>
</html>