[pgpool-hackers: 3632] Re: [PATCH] Change relative path of SSL files to configuration directory

[Tatsuo Ishii]

Hi Umar Hayat,

Done. Thank you!
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

> Thanks Peng,
> 
> Ishii San,
> Can you please update TODO for this path
> https://pgpool.net/mediawiki/index.php/TODO#Change_relative_path_of_ssl_key_and_ssl_cert_to_DEFAULT_CONFIGDIR
> 
> Regards
> 
> On Tue, May 19, 2020 at 11:40 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
> 
>> Hi Umar Hayat,
>>
>> On Mon, 18 May 2020 21:04:04 +0500
>> Umar Hayat <m.umarkiani at gmail.com> wrote:
>>
>> > Hi Peng,
>> > Any feedback ?
>>
>> Thank you for your patch.
>>
>> It have committed your patch.
>>
>> https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=fc9e9d3733a9c2c14c10bb3af25217f386ee41c7
>>
>> > Regards
>> > Umar Hayat
>> >
>> > On Thu, May 7, 2020 at 1:51 PM Umar Hayat <m.umarkiani at gmail.com> wrote:
>> >
>> > > Hi Peng,
>> > > Please find attached updated patch with absolute path support,
>> regression
>> > > test 029 covers absolute path support.
>> > >
>> > > Regards
>> > > Umar Hayat
>> > >
>> > > On Fri, May 1, 2020 at 9:39 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
>> > >
>> > >> Hi,
>> > >>
>> > >> On Mon, 27 Apr 2020 18:22:56 +0500
>> > >> Umar Hayat <m.umarkiani at gmail.com> wrote:
>> > >>
>> > >> > Hi Hackers,
>> > >> > Please find attached patch for following TODO item
>> > >> >
>> > >>
>> https://pgpool.net/mediawiki/index.php/TODO#Change_relative_path_of_ssl_key_and_ssl_cert_to_DEFAULT_CONFIGDIR
>> > >>
>> > >> Thank you for your patch.
>> > >>
>> > >> I reviewed and testet your patch.
>> > >> It seems absolute path can't be used in these parameters.
>> > >>
>> > >> Could you add the support for absolute path?
>> > >>
>> > >> > All SSL artefact files (key, cert, ca_cert, crl) paths will be
>> relative
>> > >> to
>> > >> > configuration directory (pgpool.conf path).  DEFAULT_CONFIGDIR
>> > >> > configuration always point to location what we specify at build
>> time.
>> > >> This
>> > >> > patch use the path of pgpool.conf directory path instead
>> > >> > of DEFAULT_CONFIGDIR, so that custom path of configuration can be
>> used.
>> > >> (
>> > >> > like we do in regression)
>> > >> >
>> > >> > Patch includes:
>> > >> > 1. Implementation
>> > >> > 2. Updated tests
>> > >> > 3. Update doc
>> > >> >
>> > >> > Regards,
>> > >> > Umar Hayat
>> > >> > EnterpriseDB: https://www.enterprisedb.com/
>> > >>
>> > >>
>> > >> --
>> > >> Bo Peng <pengbo at sraoss.co.jp>
>> > >> SRA OSS, Inc. Japan
>> > >>
>> > >
>>
>>
>> --
>> Bo Peng <pengbo at sraoss.co.jp>
>> SRA OSS, Inc. Japan
>>