[pgpool-hackers: 3619] Re: pgPool build error on Fedora 32

Devrim Gündüz devrim at gunduz.org
Fri May 15 18:51:17 JST 2020


Hi,

Ping?

On Fri, 2020-04-24 at 13:18 +0100, Devrim Gündüz wrote:
> Hi,
> 
> All pgPool versions fail to build on Fedora 32, which comes with GCC
> 10. Below
> is the output from 4.1.1. Can you please take a look?
> 
> Thanks! Devrim
> ==================================
> 
>  /usr/bin/make -j4
> In file included from ../src/include/pool.h:28,
>                  from utils/pool_process_reporting.c:23:
> utils/pool_process_reporting.c: In function 'get_config':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' output truncated
> before terminating nul copying 80 bytes from a string of the same
> length [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:231:2: note: in expansion of macro
> 'StrNCpy'
>   231 |  StrNCpy(status[i].desc, "allow to use clear text password
> auth when pool_passwd does not contain password",
> POOLCONFIG_MAXDESCLEN);
>       |  ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' output truncated
> copying 80 bytes from a string of length 88 [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:894:2: note: in expansion of macro
> 'StrNCpy'
>   894 |  StrNCpy(status[i].desc, "Total memory size in bytes for
> storing memory cache. Mandatory if memqcache_method=shmem",
> POOLCONFIG_MAXDESCLEN);
>       |  ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' output truncated
> copying 80 bytes from a string of length 173 [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:909:2: note: in expansion of macro
> 'StrNCpy'
>   909 |  StrNCpy(status[i].desc, "If true, invalidation of query
> cache is triggered by corresponding DDL/DML/DCL(and
> memqcache_expire).  If false, it is only triggered  by
> memqcache_expire.  True by default.", POOLCONFIG_MAXDESCLEN);
>       |  ^~~~~~~
> utils/pool_process_reporting.c: In function 'get_nodes':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> depends on the length of the source argument [-Wstringop-overflow=]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:1258:3: note: in expansion of macro
> 'StrNCpy'
>  1258 |   StrNCpy(nodes[i].hostname, bi->backend_hostname, strlen(bi-
> >backend_hostname) + 1);
>       |   ^~~~~~~
> utils/pool_process_reporting.c:1258:52: note: length computed here
>  1258 |   StrNCpy(nodes[i].hostname, bi->backend_hostname, strlen(bi-
> >backend_hostname) + 1);
>       |                                                    ^~~~~~~~~~
> ~~~~~~~~~~~~~~~~~~
> ../src/include/pool_type.h:400:16: note: in definition of macro
> 'StrNCpy'
>   400 |   Size _len = (len); \
>       |                ^~~
> utils/pool_process_reporting.c: In function 'get_pools':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' output may be
> truncated copying 63 bytes from a string of length 63 [-Wstringop-
> truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:1513:6: note: in expansion of macro
> 'StrNCpy'
>  1513 |      StrNCpy(pools[lines].database, pi-
> >connection_info[poolBE].database, POOLCONFIG_MAXIDENTLEN);
>       |      ^~~~~~~
> utils/pool_process_reporting.c: In function 'get_processes':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' output may be
> truncated copying 63 bytes from a string of length 63 [-Wstringop-
> truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> utils/pool_process_reporting.c:1707:5: note: in expansion of macro
> 'StrNCpy'
>  1707 |     StrNCpy(processes[child].database, pi-
> >connection_info[poolBE].database, POOLCONFIG_MAXIDENTLEN);
>       |     ^~~~~~~
> pool_config.l: In function 'add_regex_pattern':
> pool_config.l:168:3: warning: 'strncpy' specified bound depends on
> the length of the source argument [-Wstringop-overflow=]
> pool_config.l:168:32: note: length computed here
> pool_config.l:166:3: warning: 'strncat' specified bound depends on
> the length of the source argument [-Wstringop-overflow=]
> pool_config.l:166:32: note: length computed here
> pcp_con/pcp_worker.c: In function 'pcp_worker_main':
> pcp_con/pcp_worker.c:1137:20: warning: 'authenticated' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>  1137 |  if (!*random_salt || !authenticated)
>       |      ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
> pcp_con/pcp_worker.c:1131:8: note: 'authenticated' was declared here
>  1131 |  int   authenticated;
>       |        ^~~~~~~~~~~~~
> In file included from ../src/include/pool.h:28,
>                  from context/pool_session_context.c:25:
> context/pool_session_context.c: In function
> 'pool_pending_message_query_set':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 1024 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1216:2: note: in expansion of macro
> 'StrNCpy'
>  1216 |  StrNCpy(message->query, query_context->original_query,
> sizeof(message->query));
>       |  ^~~~~~~
> context/pool_session_context.c: In function
> 'pool_pending_message_add':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1253:5: note: in expansion of macro
> 'StrNCpy'
>  1253 |     StrNCpy(message->portal, message->contents + 1,
> sizeof(message->portal));
>       |     ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1251:5: note: in expansion of macro
> 'StrNCpy'
>  1251 |     StrNCpy(message->statement, message->contents + 1,
> sizeof(message->statement));
>       |     ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1245:4: note: in expansion of macro
> 'StrNCpy'
>  1245 |    StrNCpy(message->portal, message->contents,
> sizeof(message->portal));
>       |    ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1240:4: note: in expansion of macro
> 'StrNCpy'
>  1240 |    StrNCpy(message->portal, message->contents,
> sizeof(message->portal));
>       |    ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1241:4: note: in expansion of macro
> 'StrNCpy'
>  1241 |    StrNCpy(message->statement, message->contents +
> strlen(message->contents) + 1, sizeof(message->statement));
>       |    ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1235:4: note: in expansion of macro
> 'StrNCpy'
>  1235 |    StrNCpy(message->statement, message->contents,
> sizeof(message->statement));
>       |    ^~~~~~~
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 1024 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1236:4: note: in expansion of macro
> 'StrNCpy'
>  1236 |    StrNCpy(message->query, message->contents +
> strlen(message->contents) + 1, sizeof(message->query));
>       |    ^~~~~~~
> context/pool_session_context.c: In function 'pool_temp_tables_add':
> ../src/include/pool_type.h:404:4: warning: 'strncpy' specified bound
> 128 equals destination size [-Wstringop-truncation]
>   404 |    strncpy(_dst, (src), _len); \
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
> context/pool_session_context.c:1878:3: note: in expansion of macro
> 'StrNCpy'
>  1878 |   StrNCpy(table->tablename, tablename, sizeof(table-
> >tablename));
>       |   ^~~~~~~
> /usr/bin/ld: protocol/child.o:(.bss+0x460): multiple definition of
> `remote_ps_data'; main/health_check.o:(.bss+0x0): first defined here
> /usr/bin/ld: streaming_replication/pool_worker_child.o:(.bss+0x0):
> multiple definition of `remote_ps_data';
> main/health_check.o:(.bss+0x0): first defined here
> collect2: error: ld returned 1 exit status
> make[3]: *** [Makefile:768: pgpool] Error 1
> =================
> 
> 
> _______________________________________________
> pgpool-hackers mailing list
> pgpool-hackers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
-- 
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200515/fcfac467/attachment.sig>


More information about the pgpool-hackers mailing list