[pgpool-hackers: 3250] Re: select(2) storm

Tatsuo Ishii ishii at sraoss.co.jp
Fri Feb 22 11:09:55 JST 2019


> Hi,
> 
> On 2/19/19 8:33 PM, Tatsuo Ishii wrote:
>> Attached is a patch trying eliminate calls to pool_check_fd() (the
>> same one I sent to you privately. I just wanted to share with other
>> developers).
>> The idea is checking select(2) timeout parameter set in a static
>> variable in pool_read() and pool_read2(). If it's -1, it means no
>> select timeout will be set in pool_check_fd(), which implies we can
>> avoid to call pool_check_fd().
>> Also I moved pool_check_fd() and friends to pool_stream.c from a
>> modularity point of view.
>> 
> 
> 
> I see a minor speed up and the patch looks good, so I think it is a
> win overall. Please, merge.

Done. (only to master branch because the speed up is minor).
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list