[pgpool-hackers: 3097] Re: Pgpool-II 4.0 alpha2 show-stoppers

[Muhammad Usama]

Hi

Thanks Hoshiai, for the patch.
Since we haven't got the decision on the pool_passwd file descriptor
retention,
So I have committed your patch fwith some modifications.

Thanks
Best Regards
Muhammad Usama


On Fri, Oct 26, 2018 at 12:43 PM Takuma Hoshiai <hoshiai at sraoss.co.jp>
wrote:

> Hi,
>
> Just I created a patch about bug419 too, so will share it.
>
> I understand that pool_passwd allow plain password with Pgpool-II 4.0. So
> I think to need some string buffer length changed.
>
> For your reference.
>
> Best Regards.
>
> On Thu, 25 Oct 2018 19:38:06 +0500
> Muhammad Usama <m.usama at gmail.com> wrote:
>
> > Hi
> >
> > Please find the attached patch to fix the pool_passwd file corruption
> issue
> > pointed out by Jesper.
> > Along with the corruption fix I have also made some changes to how
> > pool_passwd file is read, previously
> > we used to open this file at the startup time and keep the file
> descriptor
> > opened for the whole lifecycle.
> > Now with this patch I have modified this behaviour and the pool_passwd is
> > only opened when it is needed and
> > closed afterwards.
> >
> > Am I missing something obvious here or do you agree with this change.
> >
> > Thanks
> > Best Regards
> > Muhammad Usama
> >
> >
> >
> >
> > On Mon, Oct 22, 2018 at 8:41 AM Bo Peng <pengbo at sraoss.co.jp> wrote:
> >
> > > Hi Jesper,
> > >
> > > Thank you for reporting this issue.
> > > We will fix it.
> > >
> > > On Fri, 19 Oct 2018 07:08:51 -0400
> > > Jesper Pedersen <jesper.pedersen at redhat.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > On 10/3/18 10:36 AM, Tatsuo Ishii wrote:
> > > > >> On 8/24/18 7:46 AM, Jesper Pedersen wrote:
> > > > >>>> Please add items if I missed something.
> > > > >>> 7) 0000419: pg_md5: -m removes users
> > > > >>>      - https://www.pgpool.net/mantisbt/view.php?id=419
> > > > >>
> > > > >> This will make its way into 4.0.0, correct ?
> > > > >
> > > > > I believe so. Please let me know if you find any problem with
> pg_md5.
> > > > >
> > > >
> > > > So, this made its way into 4.0.0 which will corrupt pool_passwd;
> > > >
> > > > pg_md5 -f conf/pgpool.conf -u user1 -m user1
> > > > pg_md5 -f conf/pgpool.conf -u user2 -m user2
> > > > pg_md5 -f conf/pgpool.conf -u user3 -m user3
> > > >
> > > > cat conf/pgpool.conf
> > > > user1:md57d1b5a4329b6478e976508ab9a49ee3d
> > > > user2:md572881e285cdb0f9370dcdf1db0d9a869
> > > > user3:md516bd93afc66e593f3aeedecdf1201ee6
> > > >
> > > > pg_enc -f conf/pgpool.conf -u user1 -m user1
> > > >
> > > > cat conf/pgpool.conf
> > > > user1:AES1MLVcB4ex/cCqL24k1H8wQ==
> > > > a49ee3d
> > > > user2:md572881e285cdb0f9370dcdf1db0d9a869
> > > > user3:md516bd93afc66e593f3aeedecdf1201ee6
> > > >
> > > > pg_enc -f conf/pgpool.conf -u user2 -m user2
> > > >
> > > > cat conf/pgpool.conf
> > > > user1:AES1MLVcB4ex/cCqL24k1H8wQ==
> > > > a49ee3d
> > > > user2:md572881e285cdb0f9370dcdf1db0d9a869
> > > > user3:md516bd93afc66e593f3aeedecdf1201ee6
> > > > user2:AESFndsqgtIUnJSEr0yn1cTQA==
> > > >
> > > >
> > > > Pending patches:
> > > >
> > > >
> http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/002955.html
> > > >
> http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003017.html
> > > >
> http://www.sraoss.jp/pipermail/pgpool-hackers/2018-August/003025.html
> > > >
> > > > Best regards,
> > > >   Jesper
> > > > _______________________________________________
> > > > pgpool-hackers mailing list
> > > > pgpool-hackers at pgpool.net
> > > > http://www.pgpool.net/mailman/listinfo/pgpool-hackers
> > >
> > >
> > > --
> > > Bo Peng <pengbo at sraoss.co.jp>
> > > SRA OSS, Inc. Japan
> > >
> > > _______________________________________________
> > > pgpool-hackers mailing list
> > > pgpool-hackers at pgpool.net
> > > http://www.pgpool.net/mailman/listinfo/pgpool-hackers
> > >
>
>
> --
> Takuma Hoshiai <hoshiai at sraoss.co.jp>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20181030/b1e18699/attachment.html>