[pgpool-hackers: 3110] Re: Memory context for pool_create_relcache

[Muhammad Usama]

Hi Ishii-San

I have been thinking about this and struggling to remember the exact
reason, I think the comment
here is misleading, As far as I can remember I originally wanted to create
the session local relcache in
the session memory context but latter during testing found some issue with
that and moved it to
TopMemoryContext.
I will verify the use of session memory context for the session local
relcache and take care of this.
Sorry for the inconvenience.

Kind regards
Muhammad Usama


On Wed, Nov 7, 2018 at 7:52 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi Usama,
>
> I have noticed following code fragment in pool_create_relcache:
>
>         /*
>          * Create the relcache in session context if the cache is session
> local,
>          * otherwise make home in TopMemoryContext
>          */
>         old_context = MemoryContextSwitchTo(TopMemoryContext);
>
> Despite the comments says session context memory is used for session
> local relcache, the actual code always creates relcache in
> TopMemoryContext. Can you please elaborate why?
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20181108/0ee4afff/attachment.html>