[pgpool-hackers: 1337] Re: FW: Tables in black/white_memqcache_table_list become need to quote?

Huong Dangminh huo-dangminh at ys.jp.nec.com
Thu Jan 14 14:07:37 JST 2016


Hi Nagata-san,

> -----Original Message-----
> From: Yugo Nagata [mailto:nagata at sraoss.co.jp]
> Sent: Thursday, January 14, 2016 2:00 PM
> To: Dangminh Huong(ダンM フーン) <huo-dangminh at ys.jp.nec.com>
> Cc: pgpool-hackers at pgpool.net; Yanagisawa Hiroshi(柳澤 博)
> <hir-yanagisawa at ut.jp.nec.com>
> Subject: Re: [pgpool-hackers: 1331] FW: Tables in
> black/white_memqcache_table_list become need to quote?
> 
> Hi Houng Dangminh,
> 
> Thank you for your pointing out and sending patch!
> I have committed this.
> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=9b9d2a04
> f95d9a8c8ca2ed5cc0c724c54ee34601
> 

Thanks for applied my patch, and backporting to STABLE series.

Best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

> On Wed, 13 Jan 2016 08:16:52 +0000
> Huong Dangminh <huo-dangminh at ys.jp.nec.com> wrote:
> 
> > Hi,
> >
> > Thanks for prompt response sir,
> >
> > > -----Original Message-----
> > > From: Yugo Nagata [mailto:nagata at sraoss.co.jp]
> > > Sent: Wednesday, January 13, 2016 5:10 PM
> > > To: Dangminh Huong(ダンM フーン) <huo-dangminh at ys.jp.nec.com>
> > > Cc: pgpool-hackers at pgpool.net; Yanagisawa Hiroshi(柳澤 博)
> > > <hir-yanagisawa at ut.jp.nec.com>
> > > Subject: Re: [pgpool-hackers: 1331] FW: Tables in
> > > black/white_memqcache_table_list become need to quote?
> > >
> > > Hi,
> > >
> > > Sorry for my late reply.
> > >
> > > Yes, you are right. I confirmed the problem and your patch
> > > would fix this. I'll look into this a bit and commit this.
> > >
> >
> > Thanks,
> >
> > Best regards,
> > Dang Minh Huong
> > NEC Solution Innovators, Ltd.
> > http://www.nec-solutioninnovators.co.jp/en/
> >
> > > On Wed, 13 Jan 2016 07:51:27 +0000
> > > Huong Dangminh <huo-dangminh at ys.jp.nec.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > Sorry, I know you must be busy now,
> > > > but anyone can confirm for this mail for me?
> > > > Am i missed something? or is this the specication?
> > > >
> > > > I mean,
> > > > In pgpool-II 3.4.3 table name in black/white_memqcache_table_list
> > > > can be specified like 'table1, table2' but in V3_4_STABLE it
> > > > must be '"table1", "table2"'.
> > > >
> > > > Best regards,
> > > > ---
> > > > Dang Minh Huong
> > > > NEC Solution Innovators, Ltd.
> > > > http://www.nec-solutioninnovators.co.jp/en/
> > > >
> > > > -----Original Message-----
> > > > From: pgpool-hackers-bounces at pgpool.net
> > > [mailto:pgpool-hackers-bounces at pgpool.net] On Behalf Of ??ng Minh H??ng
> > > > Sent: Saturday, January 09, 2016 12:05 PM
> > > > To: pgpool-hackers at pgpool.net
> > > > Subject: [pgpool-hackers: 1323] Tables in
> > > black/white_memqcache_table_list become need to quote?
> > > >
> > > > Hi,
> > > >
> > > > As the result of commit 43ff7d3de9db4c8a1143258f4ffff98682dab560.
> > > > tables (also schemas) name specified in *_memqcache_table_list become
> > > > need to quoted by double quotation to match with
> > > make_table_name_from_rangevar
> > > > did.
> > > >
> > > > So i think, it is necessary to strip quote table name before
> > > pattern_compare do to fix it.
> > > > I attached a patch, which restore strip_quote function and do it in
> > > pattern_compare
> > > > before regexec.
> > > > Can you confirm it for me.
> > > >
> > > > best regards,
> > > > bocap.
> > >
> > >
> > > --
> > > Yugo Nagata <nagata at sraoss.co.jp>
> 
> 
> --
> Yugo Nagata <nagata at sraoss.co.jp>


More information about the pgpool-hackers mailing list