[pgpool-hackers: 1331] FW: Tables in black/white_memqcache_table_list become need to quote?

Huong Dangminh huo-dangminh at ys.jp.nec.com
Wed Jan 13 16:51:27 JST 2016


Hi,

Sorry, I know you must be busy now,
but anyone can confirm for this mail for me?
Am i missed something? or is this the specication?

I mean,
In pgpool-II 3.4.3 table name in black/white_memqcache_table_list 
can be specified like 'table1, table2' but in V3_4_STABLE it 
must be '"table1", "table2"'.

Best regards,
---
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

-----Original Message-----
From: pgpool-hackers-bounces at pgpool.net [mailto:pgpool-hackers-bounces at pgpool.net] On Behalf Of ??ng Minh H??ng
Sent: Saturday, January 09, 2016 12:05 PM
To: pgpool-hackers at pgpool.net
Subject: [pgpool-hackers: 1323] Tables in black/white_memqcache_table_list become need to quote?

Hi,

As the result of commit 43ff7d3de9db4c8a1143258f4ffff98682dab560.
tables (also schemas) name specified in *_memqcache_table_list become 
need to quoted by double quotation to match with make_table_name_from_rangevar 
did.

So i think, it is necessary to strip quote table name before pattern_compare do to fix it.
I attached a patch, which restore strip_quote function and do it in pattern_compare 
before regexec. 
Can you confirm it for me.

best regards,
bocap.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote.patch
Type: application/octet-stream
Size: 2877 bytes
Desc: quote.patch
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20160113/0a829cd7/attachment.obj>


More information about the pgpool-hackers mailing list