[pgpool-hackers: 1071] Re: [pgpool-committers: 2702] pgpool: Mega patch to enhance performance in extended protocol mode.

[Tatsuo Ishii]

[remving Cc: to pgpool-committers to keep the list clean]

> Ishii-san
> 
> Looking at the commit, I found that pool_sent_message_destory()
> isn't called in pool_remove_sent_message() which is commented
> out with XXX. Is it needed? I think this causes memory leak.
> 
> @@ -304,7 +317,8 @@ bool pool_remove_sent_message(char kind, const char *name)
>                 if (msglist->sent_messages[i]->kind == kind &&
>                         !strcmp(msglist->sent_messages[i]->name, name))
>                 {
> -                       pool_sent_message_destroy(msglist->sent_messages[i]);
> +                       //XXX
> +                       //pool_sent_message_destroy(msglist->sent_messages[i]);
>                         break;
>                 }
>         }

Because the commit removes most flush messages, it is possible that
pending messages remain (not yet receiving response message from
backend).

Also, the memory for sent_message is in the session context, when a
session ends, it will be freed anyway.

However the code is apparently a temporary one, I should have cleaned
earlier. Will work on it.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp