[pgpool-hackers: 1113] Re: [pgpool-committers: 2733] pgpool: Fix compiler warnings

[Tatsuo Ishii]

With this commit still tons of warnings are produced when compiled
with PostgreSQL 9.4 (or before )installed.

	gcc -DHAVE_CONFIG_H -I. -I../../src/include  -D_GNU_SOURCE -I /usr/local/pgsql/include   -g -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -MT wd_heartbeat.o -MD -MP -MF $depbase.Tpo -c -o wd_heartbeat.o wd_heartbeat.c &&\
	mv -f $depbase.Tpo $depbase.Po
In file included from ../../src/include/parser/stringinfo.h:22:0,
                 from ../../src/include/utils/elog.h:20,
                 from wd_heartbeat.c:49:
../../src/include/parser/pg_config_manual.h:69:0: warning: "SEQ_MAXVALUE" redefined [enabled by default]
 #define SEQ_MAXVALUE PG_INT64_MAX
 ^
In file included from ../../src/include/utils/palloc.h:31:0,
                 from wd_heartbeat.c:47:
/usr/local/pgsql/include/pg_config_manual.h:51:0: note: this is the location of the previous definition
 #define SEQ_MAXVALUE INT64CONST(0x7FFFFFFFFFFFFFFF)
 ^

Probably you should use #ifdef in
src/include/parser/pg_config_manual.h to avoid redefinition of
#define.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

From: Yugo Nagata <nagata at sraoss.co.jp>
Subject: [pgpool-committers: 2733] pgpool: Fix compiler warnings
Date: Fri, 16 Oct 2015 04:34:37 +0000
Message-ID: <E1Zmwiz-0006Vz-27 at gothos.postgresql.org>

> Fix compiler warnings
> 
> Branch
> ------
> master
> 
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=bb96b767624ff43a1d3ea18a2aae7147ac1cc801
> 
> Modified Files
> --------------
> src/parser/scan.c      |   28 +++++++---------------------
> src/parser/snprintf.c  |    3 +--
> src/utils/pool_path.c  |    5 ++++-
> src/utils/statistics.c |    1 +
> 4 files changed, 13 insertions(+), 24 deletions(-)
> 
> _______________________________________________
> pgpool-committers mailing list
> pgpool-committers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-committers