[pgpool-hackers: 1143] Re: [pgpool-committers: 2787] pgpool: Fix pgpool_setup to use DEFAULT_PGSOCKET_DIR in pg_config_manua

[Tatsuo Ishii]

I don't think this is a right direction to fix the problem.
pg_config_manual.h may not exist in the all of the installation of
PostgreSQL. Moreover, DEFAULT_PGSOCKET_DIR is just a default and
packers can override it by pgpool.conf or environment
variable.

Probably the right fix is adding new option to pgpool_setup and
regression script to specify where the PostgreSQL socket dir is in the
installtion.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

From: Yugo Nagata <nagata at sraoss.co.jp>
Subject: [pgpool-committers: 2787] pgpool: Fix pgpool_setup to use DEFAULT_PGSOCKET_DIR in pg_config_manua
Date: Wed, 04 Nov 2015 07:37:49 +0000
Message-ID: <E1Ztsdh-0005k0-Ju at gothos.postgresql.org>

> Fix pgpool_setup to use DEFAULT_PGSOCKET_DIR in pg_config_manual.h
> 
> Some Postgresql rpms define DEFAULT_PGSOCKET_DIR as /tmp, others as
> /var/run/postgresql. This affects not only PostgreSQL server but
> also libpq and psql.
> 
> This is a workaround for regression test. We might have to fix
> pgpool-II code to control default value of backend_hostname*.
> 
> Branch
> ------
> master
> 
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=b8a1dfe54c8172107ca60cbd58efd5a868a9bb78
> 
> Modified Files
> --------------
> src/test/pgpool_setup |   13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
> 
> _______________________________________________
> pgpool-committers mailing list
> pgpool-committers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-committers