[pgpool-hackers: 1206] Re: changing the pcp_watchdog_info

[Tatsuo Ishii]

Usama,

Looks pretty good to me but I would like Yugo confirm this.

Also I think it would be nice if pgpoolAdmin deals with this
enhancement.  Nozomi, what do you think?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

> Hi Ishii San
> 
> pcp_watchdog_info only gives the information of a single watchdog
> node which might not be enough in some certain situations. And as we are
> currently working on watchdog enhancements so I thought it would be good to
> also enhance the pcp_watchdog_info utility. I have created a patch to add
> a little more information about the watchdog cluster state and nodes in the
> output of pcp_watchdog_info.
> 
> Can you please have a look at the attached patch specially for
> 
> 1-) If you are good with all the new information shown by pcp_watchdog_info
> utility or you want to add/remove something?
> 
> 2-) inform watchdog info in pcp_worker violates the data serialization
> technique used by PCP server for other functions and adopts the JSON data
> formatted load to transmit the watchdog information to the client side.
> Although I am of the point of view that someday we should shift all the
> other functions to use JSON or some other serialization technique which is
> more adaptable and then the current proprietary format. But for the time
> being the watchdog informing part of PCP is different from all other.
> 
> with the new pcp_watchdog_info when node ID is given the utility shows the
> information of that specific node while ID =0 means the local watchdog
> node. And when no node ID is provided by user information of all nodes is
> shown
> 
> --example--
> 
> [usama at localhost pgpool]$ bin/pcp_watchdog_info -h localhost -p 9893 -U
> postgres -v
> Password:
> Watchdog Cluster Information
> Total Nodes         : 3
> Remote Nodes        : 2
> Alive Remote Nodes  : 2
> In Network Error    : NO
> Local Node Escalated: NO
> Master Node Name    : Linux_localhost.localdomain_9992
> 
> Watchdog Node Information
> Node Number    : 0
> Node Name      : Linux_localhost.localdomain_9993
> Host Name      : localhost
> Pgpool port    : 9993
> Watchdog port  : 9003
> Node priority  : 1
> status         : 7
> status Name    : STANDBY
> 
> Node Number    : 1
> Node Name      : Linux_localhost.localdomain_9992
> Host Name      : localhost
> Pgpool port    : 9992
> Watchdog port  : 9002
> Node priority  : 1
> status         : 4
> status Name    : COORDINATOR
> 
> Node Number    : 2
> Node Name      : Linux_localhost.localdomain_9991
> Host Name      : localhost
> Pgpool port    : 9991
> Watchdog port  : 9001
> Node priority  : 1
> status         : 7
> status Name    : STANDBY
> 
> 
> 
> Thanks
> Best regards
> Muhammad Usama