[pgpool-hackers: 1204] Re: [pgpool-committers: 2864] Re: pgpool: Add pgpool_adm docs.

[Tatsuo Ishii]

Thanks. I will look into this.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

> Hi
> 
> I think there is another simpler way. We can just change the Makefile of
> the pgpool_adm module to Makefile.in and then configure would substitute
> the actual value of prefix in it.
> Please see the attached patch
> 
> Thanks
> Best regards
> Muhammad Usama
> 
> 
> On Wed, Dec 9, 2015 at 6:50 PM, Muhammad Usama <m.usama at gmail.com> wrote:
> 
>>
>> On Wed, Dec 9, 2015 at 12:51 PM, Tatsuo Ishii <ishii at postgresql.org>
>> wrote:
>>
>>> Better to post to pgpool-hackers...
>>>
>>> > Usama,
>>> >
>>> > While installing pgpool_adm extension, I noticed that sometimes
>>> > pgpool_adm.so failed to load because missing reference to libpcp.so.
>>> > To fix this, I have changed src/sql/pgpool_adm/Makefile as follows:
>>> >
>>> >> SHLIB_LINK = -L../../libs/pcp/.libs -lpcp
>>> >
>>> > <S HLIB_LINK =  -L../../libs/pcp/.libs -lpcp -Wl,--as-needed
>>> -Wl,-rpath,'${libdir}',--enable-new-dtags
>>> >
>>> > Problem is, ${libdir} is expanded to the libdir where PostgreSQL's
>>> > libraries installed (including pgpool_adm.so). But my intention was
>>> > ${libdir} to point to the libdir which is not necessarily same as
>>> > PostgreSQL libdir. It's best to point to the directory (prefix/lib
>>> > where prefix is specified by configure). Any idea how to fix?
>>>
>>
>> One way to do this is to add a new Makefile.config.in file in
>> src/sql/ directory and then make the configure to generate a
>> Makefile.config by substitute the actual prefix path in it. And then
>> pgpool_adm module's Makefile can include that Makefile.config
>> Please see the attached POC patch
>>
>> Thanks
>> Best regards
>> Muhammad Usama
>>
>>
>>
>>> >
>>> > Best regards,
>>> > --
>>> > Tatsuo Ishii
>>> > SRA OSS, Inc. Japan
>>> > English: http://www.sraoss.co.jp/index_en.php
>>> > Japanese:http://www.sraoss.co.jp
>>> >
>>> >> Add pgpool_adm docs.
>>> >>
>>> >> Also enhance Makefile of pgpool_adm to replace the SHLIB_LINK to add
>>> >> modern ld flags. Still have problem though: i.e. ${libdir} should not
>>> >> be replaced by PostgreSQL's lib dir, rather than pcplib dir installing
>>> >> dir.
>>> >>
>>> >> Branch
>>> >> ------
>>> >> master
>>> >>
>>> >> Details
>>> >> -------
>>> >>
>>> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=f690f9927847c743dfa97dbd3371717a43ea4231
>>> >>
>>> >> Modified Files
>>> >> --------------
>>> >> doc/pgpool-en.html          |  315
>>> ++++++++++++++++++++++++++++++++++++++++++-
>>> >> doc/pgpool_adm.odp          |  Bin 0 -> 17456 bytes
>>> >> doc/pgpool_adm.png          |  Bin 0 -> 32437 bytes
>>> >> src/sql/pgpool_adm/Makefile |    5 +-
>>> >> 4 files changed, 317 insertions(+), 3 deletions(-)
>>> >>
>>> >> _______________________________________________
>>> >> pgpool-committers mailing list
>>> >> pgpool-committers at pgpool.net
>>> >> http://www.pgpool.net/mailman/listinfo/pgpool-committers
>>> > _______________________________________________
>>> > pgpool-committers mailing list
>>> > pgpool-committers at pgpool.net
>>> > http://www.pgpool.net/mailman/listinfo/pgpool-committers
>>> _______________________________________________
>>> pgpool-hackers mailing list
>>> pgpool-hackers at pgpool.net
>>> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
>>>
>>
>>