[pgpool-hackers: 527] Re: penultimate patch for exception and memory manager ( EXCEPTION_MGR branch)

Tatsuo Ishii ishii at postgresql.org
Wed May 21 02:03:20 JST 2014


> On Tue, May 20, 2014 at 3:17 PM, Tatsuo Ishii <ishii at postgresql.org> wrote:
> 
>> > Hi Tatsuo
>> >
>> > Thanks for merging. I was testing the master branch and found few
>> problems
>> > in the code, some of which could be hazardous, and few debug printf()s in
>> > the code. These issues are inherited by the Exception manager branch and
>> > not caused by merging.
>> > Please find the attached patch for the fix.
>>
>> Why do we need MemoryContextSwitchTo() in pool_start_query()?
>>
> 
> I am switching the memory context in pool_start_query() so that
> original_query string should get created in query context.
> ...
> query_context->original_query = pstrdup(query);
> ...
> 
> --Usama

Oh I see it now. Thanks. Continue to look at rest of patches...

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list