[pgpool-hackers: 548] Re: do_accept() obsoleted?

[Tatsuo Ishii]

> On Sun, Jun 15, 2014 at 2:37 PM, Tatsuo Ishii <ishii at postgresql.org> wrote:
> 
>> Hi Usama,
>>
>> The latest Coverity scan report on master branch says:
>>
>> *** CID 1223004:  Structurally dead code  (UNREACHABLE)
>> /src/protocol/child.c: 471 in do_accept()
>> 465         return NULL;
>> 466         fd_set      readmask;
>> 467         int fds;
>> 468             int save_errno;
>> 469
>>
>> It seems do_accept() immediately returns at line 465 in child.c. Also
>> do_accpet() is not called from anyone. Is do_accpet() obsoleted
>> function in master branch?
>>
> 
> do_accept() is replaced with wait_for_new_connections() function and is
> obsolete in master branch. Somehow function still exists in the code.
> 
> We can safely remove this function from master branch,  Do you want me to
> push the change in master branch?

Yes, could you please do so?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

> Thanks
> Usama
> 
> 
>> Best regards,
>> --
>> Tatsuo Ishii
>> SRA OSS, Inc. Japan
>> English: http://www.sraoss.co.jp/index_en.php
>> Japanese:http://www.sraoss.co.jp
>> _______________________________________________
>> pgpool-hackers mailing list
>> pgpool-hackers at pgpool.net
>> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
>>