[pgpool-hackers: 544] Re: cassert failure

Tatsuo Ishii ishii at postgresql.org
Thu Jun 5 16:19:23 JST 2014


Usama,

I have created a pgpool binary cassert enabled and the regression test
ran without any errors (for this I needed to fix the regression script
bug). Also I ran the pgpool binary with -x option enabled using
pgbench without any errors.

Please go ahead and push your changes to master branch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

> Thanks but I have just pushed changes for pgpool_setup and regression
> shell scripts. I have tested the new scripts on my Ubuntu 14.04
> (x86_64) box and Vine linux (kind of one 0f Redhat derived
> distributions) without any fails. Could you please try it out?
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
> 
>> Hi
>> 
>> I had done some changes to regression scripts, some while back for running
>> the regression on my ubuntu machine. I had not shared the patch with
>> community because I was not sure how it would behave on other systems,
>> Mainly the changes were to setup the secondary nodes using basebackup
>> instead of initdb, and I was successfully able to run regression on ubuntu
>> with the attached patch.
>> 
>> Please find the attached reference patch if it can be of any help for
>> fixing the regression script on ubuntu.
>> 
>> Thanks
>> Usama
>> 
>> 
>> 
>> On Wed, Jun 4, 2014 at 6:10 AM, Tatsuo Ishii <ishii at postgresql.org> wrote:
>> 
>>> Thanks.
>>>
>>> Will look into... (it will take a while. I recently switched my PC to
>>> Ubuntu box and it seems regression test does not run on the OS and I
>>> need to fix it).
>>>
>>> Best regards,
>>> --
>>> Tatsuo Ishii
>>> SRA OSS, Inc. Japan
>>> English: http://www.sraoss.co.jp/index_en.php
>>> Japanese:http://www.sraoss.co.jp
>>>
>>> > Hi
>>> >
>>> > Please see the attached patch which adds the --enable-cassert option to
>>> the
>>> > pgpool-II configure and once compiled with cassert enabled the assertion
>>> > checking can be enabled or disabled from command line option
>>> > (--debug-assertions or -x)
>>> >
>>> > --usama
>>> >
>>> >
>>> > On Thu, May 15, 2014 at 6:28 PM, Tatsuo Ishii <ishii at postgresql.org>
>>> wrote:
>>> >
>>> >> Hi Usama,
>>> >>
>>> >> A user reported that git master head has a problem with assertion
>>> enabled.
>>> >>
>>> >> Making all in parser
>>> >> make[2]: Entering directory `/home/t-ishii/work/
>>> >> git.postgresql.org/pgpool2/src/parser'
>>> >> gcc -DHAVE_CONFIG_H -I. -I../../src/include  -D_GNU_SOURCE -I
>>> >> ../../src/include/parser -I /usr/local/pgsql/include   -g -O2 -Wall
>>> >> -Wmissing-prototypes -Wmissing-declarations -MT copyfuncs.o -MD -MP -MF
>>> >> .deps/copyfuncs.Tpo -c -o copyfuncs.o copyfuncs.c
>>> >> copyfuncs.c: In function '_copyList':
>>> >> copyfuncs.c:2660: error: 'assert_enabled' undeclared (first use in this
>>> >> function)
>>> >> copyfuncs.c:2660: error: (Each undeclared identifier is reported only
>>> once
>>> >> copyfuncs.c:2660: error: for each function it appears in.)
>>> >> copyfuncs.c:2660: warning: passing argument 1 of 'list_length' discards
>>> >> qualifiers from pointer target type
>>> >> ../../src/include/parser/pg_list.h:100: note: expected 'struct List *'
>>> but
>>> >> argument is of type 'const struct List *'
>>> >> copyfuncs.c:2660: warning: implicit declaration of function
>>> >> 'ExceptionalCondition'
>>> >> make[2]: *** [copyfuncs.o] Error 1
>>> >> make[2]: Leaving directory `/home/t-ishii/work/
>>> >> git.postgresql.org/pgpool2/src/parser'
>>> >> make[1]: *** [all-recursive] Error 1
>>> >> make[1]: Leaving directory `/home/t-ishii/work/
>>> >> git.postgresql.org/pgpool2/src'
>>> >> make: *** [all-recursive] Error 1
>>> >>
>>> >> Besides configure does not accept --enable-cassert, I have seen the
>>> >> erros above if I manually set
>>> >>
>>> >> #define USE_ASSERT_CHECKING
>>> >>
>>> >> in pool_type.h.
>>> >>
>>> >> Best regards,
>>> >> --
>>> >> Tatsuo Ishii
>>> >> SRA OSS, Inc. Japan
>>> >> English: http://www.sraoss.co.jp/index_en.php
>>> >> Japanese: http://www.sraoss.co.jp
>>> >> _______________________________________________
>>> >> pgpool-hackers mailing list
>>> >> pgpool-hackers at pgpool.net
>>> >> http://www.pgpool.net/mailman/listinfo/pgpool-hackers
>>> >>
>>>
> _______________________________________________
> pgpool-hackers mailing list
> pgpool-hackers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-hackers


More information about the pgpool-hackers mailing list