[pgpool-hackers: 237] Re: Ideas for code cleanup
Tatsuo Ishii
ishii at postgresql.org
Sat May 11 18:19:39 JST 2013
>> > The 'doc' branch has some English documentation wording improvements,
>> > and the 'code' branch has some code and comment adjustments and
>> > questions.
>>
>> It seems doc improvements can be applied to pgpool master
>> repository. If so, please post patch when you are ready.
>
> Documentation and code patches attached.
I have applied your changes to master and v3.2-stable. Thanks.
I also applied some of your code patches to master.
I have a question: you replaced strcmp to strlen in your patches.
Why do you prefer strlen over strcmp?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
>> >> > I was also thinking that running pgindent over the code would help make
>> >> > it more consistent.
>> >>
>> >> This sounds also good. We have been following PostgreSQL coding style
>> >> but we did not use pgindent. So there may be places where the rule is
>> >> not respected.
>> >
>> > I can create a git branch with just the pgindent output, but it will be
>> > a large patch. Do you want it now? Should I create a git branch for
>> > it?
>> >
>> > The pgindent changes will be major so it would be best to do that first
>> > --- then I can start working on the function location adjustments.
>>
>> Ok, let's run pgindent when 3.5 developments starts.
>
> OK, makes sense.
>
> --
> Bruce Momjian <bruce at momjian.us> http://momjian.us
> EnterpriseDB http://enterprisedb.com
>
> + It's impossible for everything to be true. +
More information about the pgpool-hackers
mailing list