[pgpool-hackers: 309] Re: reorganisation of pgpool-II source tree

[Tatsuo Ishii]

Usama,

Thanks for the proposal. In over all I believe this will greatly help
people who are trying to understand the pgpool-II source code.  After
pgpool-II 3.3 is out (which is expected in this July), we could apply
the changes if there's no objection from pgpool-II hackers.

> Since the pgpool-II code base has grown in recent times and the code tree
> is not very much organised into directories i.e There are
> no separate directories for source and include files, and most of the pgpool-II
> source resides in top level pgpool2 directory, This makes it a little hard
> to get the quick understanding of the code for new developers,
> and maintenance of code will become more and more difficult with growth in
> code base.
> 
> So me and Tatsuo has been working on the reorganisation of pgpool-II source
> tree and have came up with the directory structure.
> The purposed source tree for the pgpool-II is to contains following
> directories.

Here are small suggestions.

I think you missed to create src/include/query_cache and you should
move src/include/utils/pool_memqcache.h there.

Also I think src/rewrite/parallel_query should not under src/rewrite
because staffs under parallel_query are not for general query
rewriting, but for parallel_query. They look similar in implementation
but their aims are completely different. If you do that way, it will
give enough confusion to those who are studying pgpool-II source code.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

> pgpool2
> |  --doc
> |  --m4
> |  --pgpool_adm
> |  --src
> |  |  --auth
> |  |  --config
> |  |  --context
> |  |  --include
> |  |  |  --auth
> |  |  |  --context
> |  |  |  --parser
> |  |  |  --pcp
> |  |  |  --protocol
> |  |  |  --rewrite
> |  |  |  --utils
> |  |  |  --watchdog
> |  |  --libs
> |  |  |  --pcp
> |  |  --main
> |  |  --parser
> |  |  --pcp_con
> |  |  --protocol
> |  |  --query_cache
> |  |  --redhat
> |  |  |  --rpm_installer
> |  |  --rewrite
> |  |  |  --parallel_query
> |  |  --sample
> |  |  --sql
> |  |  |  --pgpool-recovery
> |  |  |  --pgpool-regclass
> |  |  --streaming_replication
> |  |  --system_db
> |  |  --test
> |  |  |  --C
> |  |  |  --jdbc
> |  |  |  |  --expected
> |  |  |  --parser
> |  |  |  |  --expected
> |  |  |  |  --input
> |  |  |  --pdo-test
> |  |  |  |  --mod
> |  |  |  |  --SQLlist
> |  |  |  --regression
> |  |  |  |  --tests
> |  |  |  |  |  --001.load_balance
> |  |  |  |  |  --002.native_replication
> |  |  |  |  |  --003.failover
> |  |  |  |  |  --050.bug58
> |  |  |  |  |  --051.bug60
> |  |  |  |  |  --052.do_query
> |  |  |  |  |  --053.insert_lock_hangs
> |  |  |  --timestamp
> |  |  |  |  --expected
> |  |  |  |  --input
> |  |  --tools
> |  |  |  --pcp
> |  |  |  --pgmd5
> |  |  --utils
> |  |  --watchdog
> |  |  |  --test
> 
> 
> I have created a git repository on github (https://github.com/codeforall
> /pgpool2.git) with the purposed directory structure.
> and the attached (pgpool2_code_tree.txt) file contains the complete list
> directories along with files for the purposed directory structure.
> 
> Thanks
> 
> Regards
> Muhammad Usama