[pgpool-hackers: 74] Re: pgpool-II fails to restart using redhat/pgpool.init

[Yugo Nagata]

Hello, Devrim

I have fixed the pgpool.init to stop pgpool using by "pgpool stop -m f".
Option '-m f' is meant to stop pgpool successfully even when connected
from some frontend.

In your original pgpool.init, stop() runs "pgpool stop &" as a 
background process (with '&'). (although it is commented out...)
This allows new pgpool to start before old pgpool completely stop, 
so I removed '&'.

I have attached the patch. 
Could you please review it?

On Wed, 23 May 2012 18:56:51 -0400
Devrim GÜNDÜZ <devrim at gunduz.org> wrote:

> 
> Hi,
> 
> I'm returning from a trip today, I'll look at it on Friday or Monday.
> Still, I am not maintaining the init script in the tarball for a long
> time. Instead, I'm maintaining 
> 
> http://svn.pgrpms.org/browser/rpm/redhat/9.1/pgpool-II/EL-6/pgpool.init
> 
> (please reload the page if you get errors)
> 
> I will review the version in the tarball, and send necessary fixes.
> 
> Regards, Devrim
> 
> On Thu, 2012-05-17 at 12:07 +0900, Yugo Nagata wrote:
> > Dear Mr. Devrim
> > 
> > An problem with restart using redhat/pgpool.init has been reported to the bug
> > track.
> > http://www.pgpool.net/mantisbt/view.php?id=12
> > 
> > When pgpool is connected from frontend (e.g. psql), restart using
> > redhat/pgpool.init fails with error like 
> > "bind(/tmp/.s.PGSQL.9898) failed. reason: Address already in use".
> > 
> > There is no probrem when using `pgpool -m f stop; pgpool`.
> > Would killproc fail to close the socket properly?
> > 
> > I heard from Tatsuo Ishii that you are in charge of redhat/pgpool.init.
> > Could you respond to the issue?
> > 
> 
> 
> -- 
> Devrim GÜNDÜZ
> Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Community: devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
> http://www.gunduz.org  Twitter: http://twitter.com/devrimgunduz


-- 
Yugo Nagata <nagata at sraoss.co.jp>
SRA OSS, Inc. Japan
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pgpool.init.diff
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20120601/2e82ee3c/attachment.ksh>