<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 13, 2020 at 9:30 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Usama,<br>
<br>
Do you have an opinion on this?<br>
I feel like sherlockcpp is correct but I want to confirm it.<br>
<br></blockquote><div><br></div><div>Yes, that is correct. This is an obvious mistake in the code and somehow overlooked by commit:<span style="font-variant-ligatures:no-common-ligatures;color:rgb(159,160,28);font-family:"Meslo LG L DZ for Powerline";font-size:14px">ef6c0c8fb0899c65d37c2d83150683a952bad756</span> </div><div>Thanks sherlockcpp for pointing this out. And this also needs to be fixed in 4.0 and master branch as well.</div><div><br></div><div><br></div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
From: "sherlockcpp" <<a href="mailto:sherlockcpp@foxmail.com" target="_blank">sherlockcpp@foxmail.com</a>><br>
Subject: [pgpool-general: 6956] found some messages never output<br>
Date: Tue, 7 Apr 2020 19:08:36 +0800<br>
Message-ID: <<a href="mailto:tencent_0DE95D0F6D6F7DB17EEF3FB1@qq.com" target="_blank">tencent_0DE95D0F6D6F7DB17EEF3FB1@qq.com</a>><br>
<br>
> Hello,<br>
> <br>
> <br>
> When reading pgpool's code, I found some messages never output<br>
> in function wd_get_failover_result_from_data().<br>
> <br>
> <br>
> There are two same if condition, so the second condition is always false.<br>
> For branch4.1 ,the code is as follows.<br>
> ------------src/watchdog/wd_commands.c:721--------------------------<br>
> 723 if (result == NULL)<br>
> 724 return FAILOVER_RES_ERROR;<br>
> 725<br>
> 726 if (result == NULL)<br>
> 727 {<br>
> 728 ereport(WARNING,<br>
> 729 (errmsg("failover command on watchdog failed"),<br>
> 730 errdetail("issue command to watchdog returned NULL")));<br>
> 731 return FAILOVER_RES_ERROR;<br>
> 732 }<br>
> <br>
> --------------------------------------<br>
> <br>
> <br>
> I think the warning messages should be output here, <br>
> And I make a patch for pgpool branch 4.1.<br>
> <br>
> <br>
> Best regards<br>
> sherlockcpp<br>
</blockquote></div></div>