<div dir="ltr"><div>Hi Tatsuo</div><div><br></div><div>I have not changed/removed the 'lifecheck started" message and I am getting clean</div><div>regression including this test case.</div><div><br></div><div>testing 028.watchdog_enable_consensus_with_half_votes...ok.<br>out of 1 ok:1 failed:0 timeout:0<br></div><div><br></div><div>Can you send me the pgpool.log for a failed test case? It could be some other issue that was</div><div>preventing the pgpool-II to start up in time.</div><div><br></div>Thanks<div>Best Regards</div><div>Muhammad Usama</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 24, 2019 at 6:41 AM Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Usama,<br>
<br>
After this commit regresson 028 keeps on failing:<br>
<br>
testing 028.watchdog_enable_consensus_with_half_votes...timeout.<br>
<br>
in the regression log:<br>
<br>
waiting for watchdog node 0 starting up...<br>
<br>
The test script looks for a particular message:<br>
<br>
grep "lifecheck started" $log >/dev/null<br>
<br>
Have changed or removed the log message in your commit?<br>
<br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.jp</a><br>
<br>
From: Muhammad Usama <<a href="mailto:m.usama@gmail.com" target="_blank">m.usama@gmail.com</a>><br>
Subject: [pgpool-committers: 6193] pgpool: Adding new wd_cli utility<br>
Date: Mon, 23 Sep 2019 20:43:21 +0000<br>
Message-ID: <<a href="mailto:E1iCVB3-0007dP-8Q@gothos.postgresql.org" target="_blank">E1iCVB3-0007dP-8Q@gothos.postgresql.org</a>><br>
<br>
> Adding new wd_cli utility<br>
> <br>
> wd_cli makes it easier to integrate the external health check systems with the<br>
> Pgpool-II. It provides a very convenient and easy to use interface to interact with<br>
> watchdog and perform health check related node operations.<br>
> <br>
> For example:<br>
> If some external health-check system monitoring the health of the watchdog<br>
> cluster detects the remote node failure. It can use wd_cli utility to inform<br>
> Pgpool-II about that node failure<br>
> <br>
> $wd_cli --inform DEAD -N 'Remote watchdog name' -p 9001 -m 'node 1 failed'<br>
> <br>
> Similarly when the node becomes reachable again<br>
> <br>
> $wd_cli --inform ALIVE -N 'Remote watchdog name' -p 9001 -m 'node 1 found'<br>
> <br>
> This utility can also be used to get the live information of all nodes.<br>
> <br>
> $wd_cli -f simple_conf/watchdog/pgpool_wd1.conf --info -v --all<br>
> <br>
> Total Watchdog nodes configured for lifecheck: 2<br>
> *****************<br>
> Node ID: 0<br>
> Node Status code 4<br>
> Node Status: MASTER<br>
> Node Name: localhost:9991 Linux localhost.localdomain<br>
> Node Host: localhost<br>
> Node WD Port: 9001<br>
> Node Pgpool Port: 9991<br>
> <br>
> Node ID: 1<br>
> Node Status code 7<br>
> Node Status: STANDBY<br>
> Node Name: localhost:9992 Linux localhost.localdomain<br>
> Node Host: localhost<br>
> Node WD Port: 9002<br>
> Node Pgpool Port: 9992<br>
> <br>
> wd_cli provides many options for node search criteria.<br>
> See wd_cli --help for complete list of options.<br>
> <br>
> The commit also re-arrange the code related to socket communication and<br>
> watchdog IPC commands and separates the internal and external watchdog<br>
> commands to make the code structure more modular.<br>
> <br>
> The regression tests and documentation updates are not part of this commit<br>
> and will be taken care of separately.<br>
> <br>
> Branch<br>
> ------<br>
> master<br>
> <br>
> Details<br>
> -------<br>
> <a href="https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6156534a7073bc6446b9bcccc1ed4a846fa82f34" rel="noreferrer" target="_blank">https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=6156534a7073bc6446b9bcccc1ed4a846fa82f34</a><br>
> <br>
> Modified Files<br>
> --------------<br>
> configure | 3 +-<br>
> <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 +-<br>
> src/Makefile.am | 1 +<br>
> src/Makefile.in | 17 +-<br>
> src/include/utils/fe_ports.h | 13 +-<br>
> src/include/utils/json_writer.h | 2 +-<br>
> src/include/utils/pool_stream.h | 7 +-<br>
> src/include/utils/socket_stream.h | 36 +<br>
> src/include/watchdog/wd_commands.h | 66 ++<br>
> .../{wd_ipc_commands.h => wd_internal_commands.h} | 66 +-<br>
> src/include/watchdog/wd_ipc_conn.h | 57 ++<br>
> src/include/watchdog/wd_ipc_defines.h | 2 +-<br>
> src/include/watchdog/wd_json_data.h | 14 -<br>
> src/include/watchdog/wd_lifecheck.h | 4 +-<br>
> src/main/pgpool_main.c | 10 +-<br>
> src/pcp_con/pcp_worker.c | 4 +-<br>
> src/pcp_con/recovery.c | 2 +-<br>
> src/protocol/child.c | 16 +-<br>
> src/protocol/pool_connection_pool.c | 4 +-<br>
> src/protocol/pool_process_query.c | 8 +-<br>
> src/tools/Makefile.am | 7 +-<br>
> src/tools/Makefile.in | 7 +-<br>
> src/tools/watchdog/Makefile.am | 74 ++<br>
> src/tools/watchdog/Makefile.in | 771 +++++++++++++++++++++<br>
> src/tools/watchdog/wd_cli.c | 749 ++++++++++++++++++++<br>
> src/utils/pool_stream.c | 138 +---<br>
> src/utils/psprintf.c | 4 +-<br>
> src/utils/socket_stream.c | 195 ++++++<br>
> src/watchdog/Makefile.am | 2 +<br>
> src/watchdog/Makefile.in | 3 +<br>
> src/watchdog/watchdog.c | 14 +-<br>
> src/watchdog/wd_commands.c | 757 ++++----------------<br>
> src/watchdog/wd_internal_commands.c | 496 +++++++++++++<br>
> src/watchdog/wd_ipc_conn.c | 282 ++++++++<br>
> src/watchdog/wd_json_data.c | 86 ---<br>
> src/watchdog/wd_lifecheck.c | 12 +-<br>
> 36 files changed, 2946 insertions(+), 985 deletions(-)<br>
> <br>
</blockquote></div></div></div>