<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 25, 2017 at 11:45 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@sraoss.co.jp" target="_blank">ishii@sraoss.co.jp</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Unfortunately you commit does not improve things. The issue is<br>
probably harmless for users. Let it leave as it is for now.<br></blockquote><div><br></div><div>:-( Yes it should be harmless for the users, anyhow I will keep an eye on this one and try to get it fixed as soon as I get some idea.</div><div><br></div><div>Thanks</div><div>Best Regards</div><div>Muhammad Usama</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
Best regards,<br>
--<br>
Tatsuo Ishii<br>
SRA OSS, Inc. Japan<br>
English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
<br>
> Hi Ishii-San<br>
><br>
> Despite my utmost efforts I am not able to reproduce the issue, I have gone<br>
> through the watchdog code and also have used emacs shell but still no luck.<br>
> My hunch is that the garbage character is emitted somehow by the watchdog<br>
> test script and not by the watchdog itself,<br>
> So I have made few changes in the test script.<br>
> Can you please try running the watchdog test case by pulling the latest<br>
> regression related changes I have just pushed<br>
> because other than that I am really clueless on this at the point.<br>
><br>
> Thanks<br>
> Best Regards<br>
> Muhammad Usama<br>
><br>
><br>
> On Tue, Jul 25, 2017 at 5:21 AM, Tatsuo Ishii <<a href="mailto:ishii@sraoss.co.jp">ishii@sraoss.co.jp</a>> wrote:<br>
><br>
>> Usama,<br>
>><br>
>> I have taken look at a little bit. Since the regression script<br>
>> redirects everything (stdout and stderr) of the out of the test driver<br>
>> (in this case src/test/regress/tests/004.<wbr>watchdog/test.sh) to<br>
>> src/regression/log/004.<wbr>watchdog, the garbase must not come from stdout<br>
>> or stderr. It is likely the garbage is put to the tty device directly.<br>
>><br>
>> By changing regress.sh so that it does not redirect everything,<br>
>><br>
>> # timeout $TIMEOUT ./test.sh > $log/$i 2>&1<br>
>> timeout $TIMEOUT ./test.sh<br>
>><br>
>> and run the test, I found the garbage was produced right before line<br>
>> 42 of test.sh:<br>
>> echo -n "creating standby pgpool..."<br>
>><br>
>> So my guess is, while master watchdog is starting up, something is<br>
>> writing a garbage to the tty device directly.<br>
>><br>
>> Best regards,<br>
>> --<br>
>> Tatsuo Ishii<br>
>> SRA OSS, Inc. Japan<br>
>> English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
>> Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
>><br>
>> > Usama,<br>
>> ><br>
>> > Thanks for the commit. Unfortunately I still get the garbage output.<br>
>> ><br>
>> > t-ishii@localhost: ./regress.sh 004<br>
>> > creating pgpool-II temporary installation ...<br>
>> > moving pgpool_setup to temporary installation path ...<br>
>> > using pgpool-II at /home/t-ishii/work/pgpool-II/<br>
>> current/pgpool2/src/test/<wbr>regression/temp/installed<br>
>> > *************************<br>
>> > REGRESSION MODE : install<br>
>> > PGPOOL-II : /home/t-ishii/work/pgpool-II/<wbr>current/pgpool2/src/test/<br>
>> regression/temp/installed<br>
>> > PostgreSQL bin : /usr/local/pgsql/bin<br>
>> > pgbench : /usr/local/pgsql/bin/pgbench<br>
>> > PostgreSQL jdbc : /usr/local/pgsql/share/<wbr>postgresql-9.2-1003.jdbc4.jar<br>
>> > *************************<br>
>> > testing 004.watchdog... ok.<br>
>> > out of 1 ok:1 failed:0 timeout:0<br>
>> > --<br>
>> > Tatsuo Ishii<br>
>> > SRA OSS, Inc. Japan<br>
>> > English: <a href="http://www.sraoss.co.jp/index_en.php" rel="noreferrer" target="_blank">http://www.sraoss.co.jp/index_<wbr>en.php</a><br>
>> > Japanese:<a href="http://www.sraoss.co.jp" rel="noreferrer" target="_blank">http://www.sraoss.co.<wbr>jp</a><br>
>> ><br>
>> > From: Muhammad Usama <<a href="mailto:m.usama@gmail.com">m.usama@gmail.com</a>><br>
>> > Subject: [pgpool-committers: 4110] pgpool: Fix for [pgpool-hackers:<br>
>> 2400] Garbage output<br>
>> > Date: Thu, 06 Jul 2017 19:26:03 +0000<br>
>> > Message-ID: <<a href="mailto:E1dTCPb-0001Gd-HQ@gothos.postgresql.org">E1dTCPb-0001Gd-HQ@gothos.<wbr>postgresql.org</a>><br>
>> ><br>
>> >> Fix for [pgpool-hackers: 2400] Garbage output<br>
>> >><br>
>> >> Mostly the log messages fixes and few code cleanups.<br>
>> >><br>
>> >> Branch<br>
>> >> ------<br>
>> >> master<br>
>> >><br>
>> >> Details<br>
>> >> -------<br>
>> >> <a href="https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=" rel="noreferrer" target="_blank">https://git.postgresql.org/<wbr>gitweb?p=pgpool2.git;a=<wbr>commitdiff;h=</a><br>
>> 2b9d8aca0852aea9bcb0dc55068505<wbr>978b44bbcd<br>
>> >><br>
>> >> Modified Files<br>
>> >> --------------<br>
>> >> src/include/watchdog/wd_ipc_<wbr>defines.h | 1 -<br>
>> >> src/watchdog/watchdog.c | 99<br>
>> ++++++++++++++++++++++++------<wbr>-----<br>
>> >> 2 files changed, 69 insertions(+), 31 deletions(-)<br>
>> >><br>
>> > ______________________________<wbr>_________________<br>
>> > pgpool-committers mailing list<br>
>> > <a href="mailto:pgpool-committers@pgpool.net">pgpool-committers@pgpool.net</a><br>
>> > <a href="http://www.pgpool.net/mailman/listinfo/pgpool-committers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/<wbr>listinfo/pgpool-committers</a><br>
>><br>
</div></div></blockquote></div><br></div></div>