<div dir="ltr">Hi Ishii-San<div><br></div><div>I think there is a little problem with this commit. Since this commit is throwing ereport( ERROR,..) before "<span style="color:rgb(0,0,0);font-family:monospace;font-size:12px;white-space:pre">if</span><span style="color:rgb(0,0,0);font-family:monospace;font-size:12px;white-space:pre"> (pool_config->fail_over_on_backend_error)"</span>statementand ereport ERROR will always jump the code to error handler, and the fail_over_on_backend_error check will become ineffective.</div><div><br></div><div>Kind regards</div><div>Muhammad Usama</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 28, 2016 at 6:42 AM, Tatsuo Ishii <span dir="ltr"><<a href="mailto:ishii@postgresql.org" target="_blank">ishii@postgresql.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fix confusing error messages.<br>
<br>
pool_read() does not emit error messages when read(2) returns -1 if<br>
fail_over_on_backend_error is off. In any case the cause of error<br>
should be emitted. I do not back port this because it's a too trivial<br>
enhancement.<br>
<br>
Branch<br>
------<br>
master<br>
<br>
Details<br>
-------<br>
<a href="http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=bb41a1e55d59f842d8b97cdbb6c973c1989904aa" rel="noreferrer" target="_blank">http://git.postgresql.org/<wbr>gitweb?p=pgpool2.git;a=<wbr>commitdiff;h=<wbr>bb41a1e55d59f842d8b97cdbb6c973<wbr>c1989904aa</a><br>
<br>
Modified Files<br>
--------------<br>
src/utils/pool_stream.c | 16 ++++++----------<br>
1 file changed, 6 insertions(+), 10 deletions(-)<br>
<br>
______________________________<wbr>_________________<br>
pgpool-committers mailing list<br>
<a href="mailto:pgpool-committers@pgpool.net">pgpool-committers@pgpool.net</a><br>
<a href="http://www.pgpool.net/mailman/listinfo/pgpool-committers" rel="noreferrer" target="_blank">http://www.pgpool.net/mailman/<wbr>listinfo/pgpool-committers</a><br>
</blockquote></div><br></div>